Re: [PATCH] pinctrl: qcom: msm: constify gpio_chip structure

Path	csiph.com!goblin2!goblin.stu.neva.ru!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: qcom: msm: constify gpio_chip structure
Date	Wed, 12 Jul 2017 00:00:02 +0200
Message-ID	<u2bmi-7Ir-13@gated-at.bofh.it> (permalink)
References	<u28eK-5Oe-5@gated-at.bofh.it> <u2bcC-7F4-19@gated-at.bofh.it>
X-Original-To	Bjorn Andersson <bjorn.andersson@linaro.org>
User-Agent	Horde Application Framework 5
Content-Type	text/plain; charset=utf-8; format=flowed; DelSp=Yes
MIME-Version	1.0
Content-Disposition	inline
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - gator4166.hostgator.com
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - embeddedor.com
X-Bwhitelist	no
X-Source-IP	108.167.133.22
X-Exim-ID	1dV3A2-0028LE-Ho
X-Source-Sender	gator4166.hostgator.com [108.167.133.22]:60293
X-Source-Auth	garsilva@embeddedor.com
X-Email-Count	14
X-Source-Cap	Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	Linus Walleij <linus.walleij@linaro.org>, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 11 Jul 2017 16:57:38 -0500
X-Original-Message-ID	<20170711165738.Horde.yi2IJ5rdfgW06y48YYbFP4z@gator4166.hostgator.com>
X-Original-References	<20170711183414.GA24866@embeddedgus> <20170711214151.GC20973@minitux>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1685368

Show key headers only | View raw

Hi Bjorn,

Quoting Bjorn Andersson <bjorn.andersson@linaro.org>:

> On Tue 11 Jul 11:34 PDT 2017, Gustavo A. R. Silva wrote:
> [..]
>> In the following log you can see a significant difference in the code size
>> and data segment, hence in the dec segment. This log is the output
>
> "dec" is for "decimal" and is the sum of text, data and bss...
>

You are right. :)

>> of the size command, before and after the code change:
>>
>> before:
>>    text    data     bss     dec     hex filename
>>   13129    2808     192   16129    3f01 drivers/pinctrl/qcom/pinctrl-msm.o
>>
>> after:
>>    text    data     bss     dec     hex filename
>>   12839    2720     192   15751    3d87 drivers/pinctrl/qcom/pinctrl-msm.o
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Good catch, thanks!
>

Absolutely, glad to help!

> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Regards,
> Bjorn
>
>> ---
>>  drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c  
>> b/drivers/pinctrl/qcom/pinctrl-msm.c
>> index 273badd..245ccfd 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
>> @@ -521,7 +521,7 @@ static void msm_gpio_dbg_show(struct seq_file  
>> *s, struct gpio_chip *chip)
>>  #define msm_gpio_dbg_show NULL
>>  #endif
>>
>> -static struct gpio_chip msm_gpio_template = {
>> +static const struct gpio_chip msm_gpio_template = {
>>  	.direction_input  = msm_gpio_direction_input,
>>  	.direction_output = msm_gpio_direction_output,
>>  	.get_direction    = msm_gpio_get_direction,
>> --
>> 2.5.0
>>

--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: qcom: msm: constify gpio_chip structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-11 20:40 +0200
  Re: [PATCH] pinctrl: qcom: msm: constify gpio_chip structure Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-07-11 23:50 +0200
    Re: [PATCH] pinctrl: qcom: msm: constify gpio_chip structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-12 00:00 +0200

csiph-web