Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685334

Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port

Show all headers | View raw

On Tue, Jul 11, 2017 at 04:16:23PM -0400, Sinan Kaya wrote:
> On 7/11/2017 3:58 PM, Bjorn Helgaas wrote:
> > I'm trying to avoid pci_walk_bus() because it's such a minefield as
> > far as hot-added devices.  I don't think we can avoid one in the
> > quirk, to turn off extended tags for any devices we've already found,
> > but I think we *can* avoid adding more i
> 
> Jike Song asked what if you attach a PCIe endpoint that has an extended
> tags quirk to think about the reverse direction. That's why, I was walking
> the entire bus. 

My proposal handles endpoints, too.  The pci_walk_bus() in the quirk
handles all devices we've already enumerated, and all devices we'll
enumerate in the future are handled in pci_configure_device().

> We can maybe hold onto putting such a generic code until such a device
> with quirk actually shows up.
> 
> I'll pull your suggestion into a patch, give it a try and then post the
> next version.
> 
> -- 
> Sinan Kaya
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
> Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port Sinan Kaya <okaya@codeaurora.org> - 2017-07-11 17:30 +0200
  Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100  Root Port Bjorn Helgaas <helgaas@kernel.org> - 2017-07-11 22:00 +0200
    Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100  Root Port Sinan Kaya <okaya@codeaurora.org> - 2017-07-11 22:20 +0200
      Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100  Root Port Bjorn Helgaas <helgaas@kernel.org> - 2017-07-11 22:50 +0200
        Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100  Root Port Sinan Kaya <okaya@codeaurora.org> - 2017-07-12 15:10 +0200
          Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100  Root Port Bjorn Helgaas <helgaas@kernel.org> - 2017-07-12 21:50 +0200
            Re: [PATCH V3 1/2] PCI: Add Extended Tags quirk for Broadcom HT2100  Root Port Sinan Kaya <okaya@codeaurora.org> - 2017-07-12 21:50 +0200

csiph-web