Re: [PATCH 1/4] kasan: support alloca() poisoning

From	Greg Hackmann <ghackmann@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] kasan: support alloca() poisoning
Date	2017-07-14 01:00 +0200
Message-ID	<u2Vfs-3eR-1@gated-at.bofh.it> (permalink)
References	<u0n8d-3bI-5@gated-at.bofh.it> <u0n8d-3bI-3@gated-at.bofh.it> <u2Vfs-3eR-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/10/2017 03:30 AM, Andrey Ryabinin wrote:
> gcc now supports this too. So I think this patch should enable it.
> It's off by default so you'll have to add --param asan-instrument-allocas=1 into cflags
> to make it work

Thanks, will fix.  For now, it looks like I'll need to build gcc from 
git to test this?

>>   lib/test_kasan.c  | 22 ++++++++++++++++++++++
> 
> Tests would be better as a separate patch.

I was following the precedent in 828347f8f9a5 ("kasan: support 
use-after-scope detection") which added both at the same time.  But I 
can split the test off into a separate patch if you feel really strongly 
about it.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] kasan: support alloca() poisoning Greg Hackmann <ghackmann@google.com> - 2017-07-07 00:10 +0200
  Re: [PATCH 1/4] kasan: support alloca() poisoning Greg Hackmann <ghackmann@google.com> - 2017-07-07 02:10 +0200
  Re: [PATCH 1/4] kasan: support alloca() poisoning Dmitry Vyukov <dvyukov@google.com> - 2017-07-10 10:50 +0200
    Re: [PATCH 1/4] kasan: support alloca() poisoning Greg Hackmann <ghackmann@google.com> - 2017-07-14 00:50 +0200
      Re: [PATCH 1/4] kasan: support alloca() poisoning Dmitry Vyukov <dvyukov@google.com> - 2017-07-14 08:20 +0200
  Re: [PATCH 1/4] kasan: support alloca() poisoning Greg Hackmann <ghackmann@google.com> - 2017-07-14 01:00 +0200

csiph-web