Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces
Date	2017-07-13 18:30 +0200
Message-ID	<u2Pa1-7UJ-1@gated-at.bofh.it> (permalink)
References	<u2IBA-3Pg-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Thu, 13 Jul 2017 10:57:40 +0200

> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> 
> This change fixes following problem
> 
> [    1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2
> 
> which leads to a missing ethernet interface (reproducable at least on
> Gigabyte MP30-AR0 and APM Mustang systems).
> 
> The check for a valid clk resource fails, because DT doesn't provide a
> clock for sgenet1. But the driver doesn't use this clk, if the ethernet
> port is connected via SGMII. Therefore this patch avoids probing for clk
> on SGMII interfaces.

Applied, thanks.

> Fixes: 9aea7779b764 drivers: net: xgene: Fix crash on DT systems

Please put the commit header text inside of parenthesis and double quotes,
like this:

Fixes: 9aea7779b764 ("drivers: net: xgene: Fix crash on DT systems")

I fixed it up for you this time.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces Thomas Bogendoerfer <tsbogend@alpha.franken.de> - 2017-07-13 11:30 +0200
  Re: [PATCH net] xgene: Don't fail probe, if there is no clk  resource for SGMII interfaces David Miller <davem@davemloft.net> - 2017-07-13 18:30 +0200

csiph-web