Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686597

Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS bits

Show all headers | View raw

On Tue, 11 Jul 2017, Dmitry Torokhov wrote:

> Now that input core insists on having dev->absinfo when device claims to
> generate EV_ABS in its dev->evbit, we should not be blindly setting that
> bit.
> 
> The code in question might have been needed before input_set_abs_params()
> started setting EV_ABS in device's evbit, but not anymore, and is now
> breaking devices such as SMART SPNL-6075 Touchscreen.
> 
> Fixes: 6ecfe51b4082 ("Input: refuse to register absolute devices ...")
> Reported-by: Matthias Fend <Matthias.Fend@wolfvision.net>
> Tested-by: Matthias Fend <Matthias.Fend@wolfvision.net>
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> 
> Jiri, Benjamin, I marked it for stable as it causes regressions in 4.12
> reported by users. Please take a look.

Thanks for a quick fix, Dmitry. Queued in for-4.13/upstream-fixes branch.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS bits Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-07-11 19:10 +0200
  Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS bits Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-07-12 09:40 +0200
  Re: [PATCH] HID: multitouch: do not blindly set EV_KEY or EV_ABS  bits Jiri Kosina <jikos@kernel.org> - 2017-07-13 17:00 +0200

csiph-web