Re: [patch] staging: speakup: safely close tty

From	Okash Khawaja <okash.khawaja@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [patch] staging: speakup: safely close tty
Date	2017-07-13 13:30 +0200
Message-ID	<u2KtI-4Y8-11@gated-at.bofh.it> (permalink)
References	<u0GXg-8nH-3@gated-at.bofh.it> <u1Fw5-4xw-1@gated-at.bofh.it> <u20Ke-15l-21@gated-at.bofh.it> <u2uyB-3hF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 12, 2017 at 07:25:22PM +0100, Alan Cox wrote:
> > spk_ttyio_initialise_ldisc is called separately for each module (e.g.
> > speakup_apollo, speakup_ltlk etc) when it is loaded. spk_ttyio_release
> > is also called separately for each module when it is unloaded. The ldisc
> > stays around until the last of the modules is unloaded.
> 
> What guarantees that someone hasn't decided to set the ldisc on unrelated
> hardware to speakup (eg on a pty/tty pair).
> > 
> > > 
> > > I'd also btw strongly recommend putting the ldisc and the speakup tty
> > > driver as different modules.  
> > Sure, that makes sense. I will do that following these patches.
> 
> If the ldisc is just unregistered when the module implementing it is
> unloaded then the ref counts on the ldisc module should do everything
> needed if the above isn't correctly handled, and if it is will still be
> cleaner.

Right, I understand now. Thanks. I will update and resend this patch.

Thread

[patch] staging: speakup: safely close tty Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-07 21:20 +0200
  Re: [patch] staging: speakup: safely close tty Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-07-10 14:00 +0200
    Re: [patch] staging: speakup: safely close tty Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-11 12:40 +0200
      Re: [patch] staging: speakup: safely close tty Alan Cox <gnomes@lxorguk.ukuu.org.uk> - 2017-07-12 20:30 +0200
        Re: [patch] staging: speakup: safely close tty Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-13 13:30 +0200
        [patch v2 0/1] staging: speakup: safely close tty Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-16 11:40 +0200
          [patch v2 1/1] staging: speakup: safely close tty Okash Khawaja <okash.khawaja@gmail.com> - 2017-07-16 11:40 +0200

csiph-web