[PATCH 08/12] staging: ccree: avoid constant comparison

From	Gilad Ben-Yossef <gilad@benyossef.com>
Newsgroups	linux.kernel
Subject	[PATCH 08/12] staging: ccree: avoid constant comparison
Date	2017-07-13 10:30 +0200
Message-ID	<u2HFv-3bI-9@gated-at.bofh.it> (permalink)
References	<u2HFv-3bI-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Re-write predicate to avoid constant comparison.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
 drivers/staging/ccree/ssi_aead.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index dab4914..8a1c408 100644
--- a/drivers/staging/ccree/ssi_aead.c
+++ b/drivers/staging/ccree/ssi_aead.c
@@ -1573,7 +1573,7 @@ static int config_ccm_adata(struct aead_request *req)
 
 	/* taken from crypto/ccm.c */
 	/* 2 <= L <= 8, so 1 <= L' <= 7. */
-	if (2 > l || l > 8) {
+	if (l < 2 || l > 8) {
 		SSI_LOG_ERR("illegal iv value %X\n", req->iv[0]);
 		return -EINVAL;
 	}
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 08/12] staging: ccree: avoid constant comparison Gilad Ben-Yossef <gilad@benyossef.com> - 2017-07-13 10:30 +0200

csiph-web