Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686320

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

Show key headers only | View raw

Hi Takashi,

Quoting Takashi Iwai <tiwai@suse.de>:

> Gustavo,
>
> please stop posting in this style.  It's really annoying to see
> spontaneously popping-up almost same patch for more than two hours
> long.
>
> If you have a series of the same fix patches, send them as a patch
> set in a shot with a thread.  git-send-email does it right.
>

I will do that.

Thanks for the suggestion.
--
Gustavo A. R. Silva

> I don't mind a couple of patches posted separately, but this is over
> the limit.
>
>
> thanks,
>
> Takashi
>
> On Thu, 13 Jul 2017 09:23:51 +0200,
> Gustavo A. R. Silva wrote:
>>
>> This structure is only stored in the ops field of a snd_soc_dai_driver
>> structure. That field is declared const, so snd_soc_dai_ops structures
>> that have this property can be declared as const also.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  sound/soc/fsl/fsl_asrc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
>> index 8cfffa7..806d399 100644
>> --- a/sound/soc/fsl/fsl_asrc.c
>> +++ b/sound/soc/fsl/fsl_asrc.c
>> @@ -542,7 +542,7 @@ static int fsl_asrc_dai_trigger(struct  
>> snd_pcm_substream *substream, int cmd,
>>  	return 0;
>>  }
>>
>> -static struct snd_soc_dai_ops fsl_asrc_dai_ops = {
>> +static const struct snd_soc_dai_ops fsl_asrc_dai_ops = {
>>  	.hw_params    = fsl_asrc_dai_hw_params,
>>  	.hw_free      = fsl_asrc_dai_hw_free,
>>  	.trigger      = fsl_asrc_dai_trigger,
>> --
>> 2.5.0
>>
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-13 09:30 +0200
  Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops      structure Takashi Iwai <tiwai@suse.de> - 2017-07-13 09:40 +0200
    Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-13 09:40 +0200
    Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure Mark Brown <broonie@kernel.org> - 2017-07-13 12:20 +0200
      Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-13 17:20 +0200
        Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure Joe Perches <joe@perches.com> - 2017-07-13 20:20 +0200
          Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-13 23:20 +0200
          Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure Joe Perches <joe@perches.com> - 2017-07-14 13:10 +0200
            Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure Mark Brown <broonie@kernel.org> - 2017-07-14 13:30 +0200
              Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 06:30 +0200
          Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops  structure Mark Brown <broonie@kernel.org> - 2017-07-14 13:10 +0200

csiph-web