[PATCH] bpf: fix return in bpf_skb_adjust_net

From	Kefeng Wang <wangkefeng.wang@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] bpf: fix return in bpf_skb_adjust_net
Date	2017-07-13 08:40 +0200
Message-ID	<u2FX4-240-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The bpf_skb_adjust_net() ignores the return value of bpf_skb_net_shrink/grow,
and always return 0, fix it by return 'ret'.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 net/core/filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/filter.c b/net/core/filter.c
index c7f7370..f44fc22 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2248,7 +2248,7 @@ static int bpf_skb_adjust_net(struct sk_buff *skb, s32 len_diff)
 		       bpf_skb_net_grow(skb, len_diff_abs);
 
 	bpf_compute_data_end(skb);
-	return 0;
+	return ret;
 }
 
 BPF_CALL_4(bpf_skb_adjust_room, struct sk_buff *, skb, s32, len_diff,
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bpf: fix return in bpf_skb_adjust_net Kefeng Wang <wangkefeng.wang@huawei.com> - 2017-07-13 08:40 +0200
  Re: [PATCH] bpf: fix return in bpf_skb_adjust_net Daniel Borkmann <daniel@iogearbox.net> - 2017-07-13 11:30 +0200
  Re: [PATCH] bpf: fix return in bpf_skb_adjust_net David Miller <davem@davemloft.net> - 2017-07-13 18:20 +0200

csiph-web