Re: [PATCH v5 1/4] sched/deadline: Make find_later_rq() choose a closer cpu in topology

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/4] sched/deadline: Make find_later_rq() choose a closer cpu in topology
Date	2017-07-13 03:40 +0200
Message-ID	<u2BgJ-7th-3@gated-at.bofh.it> (permalink)
References	<tK7qO-5fE-9@gated-at.bofh.it> <tK7qO-5fE-25@gated-at.bofh.it> <u2pIC-g1-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 12, 2017 at 02:13:36PM +0100, Juri Lelli wrote:
> > @@ -1367,6 +1364,7 @@ static int find_later_rq(struct task_struct *task)
> >  	rcu_read_lock();
> >  	for_each_domain(cpu, sd) {
> >  		if (sd->flags & SD_WAKE_AFFINE) {

Hi,

> This is orthogonal to the proposed change, but I'm wondering if it make
> sense to do the following only for SD_WAKE_AFFINE domains. The

Actually I also wonder it..

> consideration applies to RT as well, actually. Also, find_later_rq gets
> called when trying to push tasks away as well and in that case checking
> for this flag seems inappropriate? Peter, Steve?
> 
> Thanks,
> 
> - Juri

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/4] sched/deadline: Make find_later_rq() choose a  closer cpu in topology Juri Lelli <juri.lelli@arm.com> - 2017-07-12 15:20 +0200
  Re: [PATCH v5 1/4] sched/deadline: Make find_later_rq() choose a  closer cpu in topology Byungchul Park <byungchul.park@lge.com> - 2017-07-13 03:40 +0200

csiph-web