[for-next][PATCH 2/2] ftrace: Fix uninitialized variable in match_records()

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	[for-next][PATCH 2/2] ftrace: Fix uninitialized variable in match_records()
Date	2017-07-13 03:10 +0200
Message-ID	<u2ANH-7ig-9@gated-at.bofh.it> (permalink)
References	<u2ANH-7ig-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Dan Carpenter <dan.carpenter@oracle.com>

My static checker complains that if "func" is NULL then "clear_filter"
is uninitialized.  This seems like it could be true, although it's
possible something subtle is happening that I haven't seen.

    kernel/trace/ftrace.c:3844 match_records()
    error: uninitialized symbol 'clear_filter'.

Link: http://lkml.kernel.org/r/20170712073556.h6tkpjcdzjaozozs@mwanda

Cc: stable@vger.kernel.org
Fixes: f0a3b154bd7 ("ftrace: Clarify code for mod command")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 kernel/trace/ftrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 5fb5b40b3ae8..53f6b6401cf0 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -3816,7 +3816,7 @@ match_records(struct ftrace_hash *hash, char *func, int len, char *mod)
 	int exclude_mod = 0;
 	int found = 0;
 	int ret;
-	int clear_filter;
+	int clear_filter = 0;
 
 	if (func) {
 		func_g.type = filter_parse_regex(func, len, &func_g.search,
-- 
2.10.2

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[for-next][PATCH 0/2] tracing: Hopefully the last updates for 4.13 Steven Rostedt <rostedt@goodmis.org> - 2017-07-13 03:10 +0200
  [for-next][PATCH 2/2] ftrace: Fix uninitialized variable in match_records() Steven Rostedt <rostedt@goodmis.org> - 2017-07-13 03:10 +0200

csiph-web