Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685250

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: fbtft: make const array gamma_par_mask static
Date 2017-07-11 19:50 +0200
Message-ID <u27sl-5iL-3@gated-at.bofh.it> (permalink)
References <u2790-5cu-21@gated-at.bofh.it> <u27iG-5fz-19@gated-at.bofh.it> <u27sl-5iL-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 11, 2017 at 06:39:59PM +0100, Colin Ian King wrote:
> On 11/07/17 18:30, Greg Kroah-Hartman wrote:
> > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Don't populate array gamma_par_mask on the stack but instead make it
> >> static.  Makes the object code smaller by 148 bytes:
> >>
> >> Before:
> >>    text	   data	    bss	    dec	    hex	filename
> >>    2993	   1104	      0	   4097	   1001	drivers/staging/fbtft/fb_st7789v.o
> >>
> >> After:
> >>    text	   data	    bss	    dec	    hex	filename
> >>    2757	   1192	      0	   3949	    f6d	drivers/staging/fbtft/fb_st7789v.o
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >> ---
> >>  drivers/media/usb/gspca/xirlink_cit.c | 2 +-
> >>  drivers/staging/fbtft/fb_st7789v.c    | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > Your subject doesn't match the patch :(
> 
> Got distracted by the Trump Jnr tweet. Will resend.

Dude, the best thing is to just read:
	https://whatthefuckjusthappenedtoday.com/
once a day, otherwise you will not get any work done ever again...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fbtft: make const array gamma_par_mask static Colin King <colin.king@canonical.com> - 2017-07-11 19:30 +0200
  Re: [PATCH] staging: fbtft: make const array gamma_par_mask static Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-11 19:40 +0200
    Re: [PATCH] staging: fbtft: make const array gamma_par_mask static Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-11 19:50 +0200
    Re: [PATCH] staging: fbtft: make const array gamma_par_mask static Colin Ian King <colin.king@canonical.com> - 2017-07-11 19:50 +0200

csiph-web