Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685221

Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value

Show all headers | View raw

On Mon, Jul 10, 2017 at 04:57:31PM +0800, Rui Teng wrote:
> This patch sets memory to zero directly to avoid unnecessary shift and
> bitwise operations on bool type, which can fix a sparse warning and also
> improve performance.

It does?  How did you measure the performance impact?  What was now
faster?

thanks,

greg k-h


> 
> Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 2568dfc15181..036c5c19a016 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2416,10 +2416,9 @@ static void Handle_SetMulticastFilter(struct wilc_vif *vif,
>  		goto ERRORHANDLER;
>  
>  	pu8CurrByte = wid.val;
> -	*pu8CurrByte++ = (strHostIfSetMulti->enabled & 0xFF);
> -	*pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 8) & 0xFF);
> -	*pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 16) & 0xFF);
> -	*pu8CurrByte++ = ((strHostIfSetMulti->enabled >> 24) & 0xFF);
> +	memset(pu8CurrByte, 0, 4);
> +	*pu8CurrByte = (strHostIfSetMulti->enabled & 0xFF);
> +	pu8CurrByte += 4;

Are you sure enabled isn't larger than 8 bits?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/staging/wilc1000: fix sparse warning: right shift by bigger than source value Rui Teng <rui.teng@linux.vnet.ibm.com> - 2017-07-10 11:00 +0200
  Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right  shift by bigger than source value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-11 19:10 +0200
    Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right shift  by bigger than source value Rui Teng <rui.teng@linux.vnet.ibm.com> - 2017-07-12 04:30 +0200
      Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right  shift by bigger than source value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-12 08:20 +0200
        Re: [PATCH] drivers/staging/wilc1000: fix sparse warning: right  shift by bigger than source value Joe Perches <joe@perches.com> - 2017-07-12 10:20 +0200

csiph-web