Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685213

Re: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro

Show all headers | View raw

On Thu, Jul 06, 2017 at 12:43:15PM +0530, Jaya Durga wrote:
> Replace all instances of (1 << 27) with BIT(27) to fix
> checkpatch check messages
> 
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
>  drivers/staging/lustre/lustre/include/lustre_compat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/include/lustre_compat.h b/drivers/staging/lustre/lustre/include/lustre_compat.h
> index da9ce19..686a251 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_compat.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_compat.h
> @@ -43,7 +43,7 @@
>   * set ATTR_BLOCKS to a high value to avoid any risk of collision with other
>   * ATTR_* attributes (see bug 13828)
>   */
> -#define ATTR_BLOCKS    (1 << 27)
> +#define ATTR_BLOCKS    BIT(27)

Isn't this used in lustre's userspace code?  If so, you can't use the
BIT() macro there :(

Please check before you redo this.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h: Prefer using the BIT macro Jaya Durga <rjdurga@gmail.com> - 2017-07-06 09:20 +0200
  Re: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h:  Prefer using the BIT macro Frans Klaver <fransklaver@gmail.com> - 2017-07-06 09:30 +0200
  Re: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h:  Prefer using the BIT macro Greg KH <gregkh@linuxfoundation.org> - 2017-07-11 19:10 +0200
    Re: [PATCH 8/8] Staging: lustre :lustre: include :lustre_compat.h:  Prefer using the BIT macro "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-07-12 07:20 +0200

csiph-web