Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685179

Re: [PATCH] iscsi-target: Reject immediate data underflow larger than SCSI transfer length

Show all headers | View raw

On Tue, 2017-07-11 at 00:22 -0700, Nicholas A. Bellinger wrote:
> So rejecting this case as already done in commit abb85a9b51 is the
> correct approach for >= v4.3.y.

Hello Nic,

I hope that you agree that the current target_cmd_size_check() implementation
is complicated and ugly. Patch 30/33 of the patch series I referred to in my
e-mail removes a significant number of lines of code from that function. So
my patch series not only makes target_cmd_size_check() easier to maintain and
to verify but it makes that function also faster. Hence please reconsider the
approach from my patch series. For patch 30/33, see also
https://www.spinics.net/lists/target-devel/msg15384.html.

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iscsi-target: Reject immediate data underflow larger  than SCSI transfer length "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-07-11 09:30 +0200
  Re: [PATCH] iscsi-target: Reject immediate data underflow larger than  SCSI transfer length Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-07-11 18:20 +0200
    Re: [PATCH] iscsi-target: Reject immediate data underflow larger  than SCSI transfer length "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-07-13 21:30 +0200
      Re: [PATCH] iscsi-target: Reject immediate data underflow larger than  SCSI transfer length Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-07-14 01:30 +0200

csiph-web