Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685151

Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port unavailable and standby states

Show all headers | View raw

On 07/11/2017 06:18 AM, Hannes Reinecke wrote:
> NACK.
> 
> The whole_point_  of having device handlers is to_avoid_  I/O errors
> during booting.
> 
> And the ALUA checker is prepared to handle this situation properly.
> The directio checker of course doesn't know about this, but then no-one
> expected the directio checker to work with ALUA.

I lacked that more holistic understanding. Thanks for explaining.

Now, for the sake of logging/debugging...

Any problem with patches 2 and 4?

Also, it seems the Unavailable/Standby states would not be logged
without a recheck from alua_check_sense(), since the only callers
of alua_rtpg_queue() are alua_activate() and alua_check[_sense]()
[the call from alua_check_vpd() is only in the initialization path].

Isn't there a point in scheduling a recheck once those conditions
are found in alua_check_sense() to get them logged? - since valid
path checkers won't go through that function.

(and it occurred to me that the state-change check of patch 3 can
be done there, simpler.)

cheers,

-- 
Mauricio Faria de Oliveira
IBM Linux Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] scsi_dh_alua: fix stuck I/O after unavailable/standby states Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 00:50 +0200
  [PATCH v2 3/4] scsi: scsi_dh_alua: do not print RTPG state if it remains unavailable/standby Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 00:50 +0200
    [PATCH] scsi: scsi_dh_alua: fix boolreturn.cocci warnings kbuild test robot <lkp@intel.com> - 2017-07-11 16:20 +0200
    Re: [PATCH v2 3/4] scsi: scsi_dh_alua: do not print RTPG state if it  remains unavailable/standby kbuild test robot <lkp@intel.com> - 2017-07-11 16:20 +0200
  [PATCH v2 4/4] scsi: scsi_dh_alua: add sdev_dbg() to track alua_rtpg_work() Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 00:50 +0200
  [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port unavailable and standby states Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 00:50 +0200
    Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port  unavailable and standby states Hannes Reinecke <hare@suse.de> - 2017-07-11 11:20 +0200
      Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port  unavailable and standby states Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 17:40 +0200
        Re: [PATCH v2 1/4] scsi: scsi_dh_alua: allow I/O in target port  unavailable and standby states Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 23:10 +0200
  Re: [PATCH v2 0/4] scsi_dh_alua: fix stuck I/O after  unavailable/standby states Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com> - 2017-07-11 01:00 +0200

csiph-web