Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685076

Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

Show all headers | View raw

Any comments for this little change? It's passed on 0day testing.

Thanks
Alex

On 07/07/2017 10:52 AM, Alex Shi wrote:
> We don't need to adjust prio before new pi_waiter adding. The prio
> only need update after pi_waiter change or task priority change.
> 
> Signed-off-by: Alex Shi <alex.shi@linaro.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Sebastian Siewior <bigeasy@linutronix.de>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Juri Lelli <juri.lelli@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> To: linux-kernel@vger.kernel.org
> To: Ingo Molnar <mingo@redhat.com>
> To: Peter Zijlstra <peterz@infradead.org>
> ---
>  kernel/locking/rtmutex.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
> index 28cd09e..d1fe41f 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -963,7 +963,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
>  		return -EDEADLK;
>  
>  	raw_spin_lock(&task->pi_lock);
> -	rt_mutex_adjust_prio(task);
>  	waiter->task = task;
>  	waiter->lock = lock;
>  	waiter->prio = task->prio;
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi <alex.shi@linaro.org> - 2017-07-07 05:00 +0200
  Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi <alex.shi@linaro.org> - 2017-07-11 16:40 +0200
    Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Steven Rostedt <rostedt@goodmis.org> - 2017-07-12 16:20 +0200
      Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Peter Zijlstra <peterz@infradead.org> - 2017-07-12 18:40 +0200
        Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi <alex.shi@linaro.org> - 2017-07-13 08:20 +0200
      Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio Alex Shi <alex.shi@linaro.org> - 2017-07-13 08:20 +0200

csiph-web