Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684976
| From | Anshuman Khandual <khandual@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() |
| Date | 2017-07-11 13:20 +0200 |
| Message-ID | <u21mV-1BA-1@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <u1WwW-74G-21@gated-at.bofh.it> <u1WQh-7b3-1@gated-at.bofh.it> <u1Xjl-7kC-19@gated-at.bofh.it> <u1Xjl-7kC-29@gated-at.bofh.it> <u1XCF-7G3-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/11/2017 12:46 PM, Michal Hocko wrote: > On Tue 11-07-17 08:56:04, Vlastimil Babka wrote: >> On 07/11/2017 08:50 AM, Michal Hocko wrote: >>> On Tue 11-07-17 08:26:40, Vlastimil Babka wrote: >>>> On 07/11/2017 08:03 AM, Michal Hocko wrote: >>>>> >>>>> Are you telling me that two if conditions cause more than a second >>>>> difference? That sounds suspicious. >>>> >>>> It's removing also a call to get_unmapped_area(), AFAICS. That means a >>>> vma search? >>> >>> Ohh, right. I have somehow missed that. Is this removal intentional? >> >> I think it is: "Checking for availability of virtual address range at >> the end of the VMA for the incremental size is also reduntant at this >> point." > > I though this referred to this check > if (vma->vm_next && vma->vm_next->vm_start < end) No, that check is still there in the code.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-10 13:20 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Michal Hocko <mhocko@kernel.org> - 2017-07-10 15:50 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 06:30 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Michal Hocko <mhocko@kernel.org> - 2017-07-11 08:10 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Vlastimil Babka <vbabka@suse.cz> - 2017-07-11 08:30 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Michal Hocko <mhocko@kernel.org> - 2017-07-11 09:00 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Vlastimil Babka <vbabka@suse.cz> - 2017-07-11 09:00 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Michal Hocko <mhocko@kernel.org> - 2017-07-11 09:20 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Michal Hocko <mhocko@kernel.org> - 2017-07-11 09:30 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 13:20 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 13:20 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 13:10 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Michal Hocko <mhocko@kernel.org> - 2017-07-11 13:30 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 13:10 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 11:50 +0200
Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-11 06:40 +0200
csiph-web