Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684978

Re: [PATCH 1/7] platform/x86: fujitsu-laptop: constify attribute_group structures.

Show all headers | View raw

On Tue, Jul 11, 2017 at 04:18:14PM +0530, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    7474	   1205	     24	   8703	   21ff	drivers/platform/x86/fujitsu-laptop.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    7538	   1141	     24	   8703	   21ff	drivers/platform/x86/fujitsu-laptop.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

I have no objections to this patch - it seems like the sensible thing to do
in the interests of remaining consistent with the rest of the kernel. 
Thanks Arvind.

Reviewed-by: Jonathan Woithe <jwoithe@just42.net>

Regards
  jonathan

> ---
>  drivers/platform/x86/fujitsu-laptop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index c1a8528..7973342 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -317,7 +317,7 @@ static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
>  	NULL
>  };
>  
> -static struct attribute_group fujitsu_pf_attribute_group = {
> +static const struct attribute_group fujitsu_pf_attribute_group = {
>  	.attrs = fujitsu_pf_attributes
>  };
>  
> -- 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Constify platform/x86 attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
  [PATCH 2/7] platform/x86: compal-laptop: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
  [PATCH 4/7] platform/x86: alienware-wmi: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
  [PATCH 3/7] platform/x86: samsung-laptop: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
  [PATCH 6/7] platform/x86: asus-wmi: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
  [PATCH 1/7] platform/x86: fujitsu-laptop: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
    Re: [PATCH 1/7] platform/x86: fujitsu-laptop: constify  attribute_group structures. Jonathan Woithe <jwoithe@just42.net> - 2017-07-11 13:20 +0200
  [PATCH 7/7] platform/x86: toshiba_acpi: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 12:50 +0200
  [PATCH 5/7] platform/x86: panasonic-laptop: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 13:00 +0200
  Re: [PATCH 0/7] Constify platform/x86 attribute_group structures. Darren Hart <dvhart@infradead.org> - 2017-07-11 18:30 +0200

csiph-web