Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683946

Re: [PATCH 3/3] dt-bindings: clock: amlogic,gxbb-aoclkc: Update bindings

Show all headers | View raw

On Thu, Jul 06, 2017 at 12:24:23PM +0200, Neil Armstrong wrote:
> On the first revision of the bindings, only the gates + resets were known
> in the AO Clock HW, but more registers used to configures AO clock are known
> to be spread among the AO register space.
> This patch adds these registers to the Ao Clock bindings with direct access
> and shared extcon access.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  .../devicetree/bindings/clock/amlogic,gxbb-aoclkc.txt         | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

This looks like the binding might be too specific with a reg list of 
single registers, and you should define a system controller node 
instead. Depends on what else is in the "A0" block.

Acked-by: Rob Herring <robh@kernel.org>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] clk: meson: gxbb-aoclk: Add CEC 32k clock Neil Armstrong <narmstrong@baylibre.com> - 2017-07-06 12:30 +0200
  [PATCH 1/3] dt-bindings: clock: gxbb-aoclk: Add CEC 32k clock Neil Armstrong <narmstrong@baylibre.com> - 2017-07-06 12:30 +0200
  [PATCH 3/3] dt-bindings: clock: amlogic,gxbb-aoclkc: Update bindings Neil Armstrong <narmstrong@baylibre.com> - 2017-07-06 12:30 +0200
    Re: [PATCH 3/3] dt-bindings: clock: amlogic,gxbb-aoclkc: Update  bindings Rob Herring <robh@kernel.org> - 2017-07-10 06:00 +0200
  [PATCH 2/3] clk: meson: gxbb-aoclk: Add CEC 32k clock Neil Armstrong <narmstrong@baylibre.com> - 2017-07-06 12:30 +0200

csiph-web