Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683910

[RESEND PATCH] mm: Don't reinvent the wheel but use existing llist API

Show all headers | View raw

Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
 mm/vmalloc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 3ca82d4..8c0eb45 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -49,12 +49,10 @@ struct vfree_deferred {
 static void free_work(struct work_struct *w)
 {
 	struct vfree_deferred *p = container_of(w, struct vfree_deferred, wq);
-	struct llist_node *llnode = llist_del_all(&p->list);
-	while (llnode) {
-		void *p = llnode;
-		llnode = llist_next(llnode);
-		__vunmap(p, 1);
-	}
+	struct llist_node *t, *llnode;
+
+	llist_for_each_safe(llnode, t, llist_del_all(&p->list))
+		__vunmap((void *)llnode, 1);
 }
 
 /*** Page table manipulation functions ***/
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] Don't reinvent the wheel but use existing llilst API Byungchul Park <byungchul.park@lge.com> - 2017-07-10 04:40 +0200
  [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-07-10 04:40 +0200
  [RESEND PATCH] mm: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-07-10 04:40 +0200
  [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-07-10 04:40 +0200
  [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park <byungchul.park@lge.com> - 2017-07-10 04:40 +0200

csiph-web