Re: [PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device documentation

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device documentation
Date	Mon, 10 Jul 2017 03:30:01 +0200
Message-ID	<u1vGp-6OF-3@gated-at.bofh.it> (permalink)
References	<u00bE-3nZ-7@gated-at.bofh.it> <u00bE-3nZ-15@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kDuHHzla0KUu7N3lTNknaly+sFnLMvmmyFdxdLlPBLw=; b=a2Ik5rAndImlZ9/c316Qpjz2UTdgRcs37enC7BO/Ggqfln1Huwo4wFIMtOb2Srab/7 vmJpMX3BQbqemtmSzgfhFnp1gwVfv54djUTn9uQ0Uca3IyktwBTBApQwyE1QSv0d6lFh xBVF8EFCWqBkDsHfp+T8i5ImSQhZQCa8eHiF7QvF7X3/7k21s+E+TOmDUAIyfiNGhJjQ OwKPbmZsaNAyro/Y0SpAXYYNgJnxSr61AC1D/8PL2lRywypsRxlwXVcQjNt+pko9yRo7 fNnFZ/0CwieRHf9niNTxSbqckLbNioEjIVI5NQwXtkfmKyrXmQfSwM83R6LVFaYi0kYx eoDQ==
X-Gm-Message-State	AIVw113S9qKGHElCrAo/QafjeMOsAO+nRJb74t36aXbDwnFUxpPWSHbL yMFMdkV8LbMYrg==
X-Received	by 10.36.250.137 with SMTP id v131mr9648959ith.97.1499649854629; Sun, 09 Jul 2017 18:24:14 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	77
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, mark.rutland@arm.com, bradleyb@fuzziesquirrel.com, jk@ozlabs.org, cbostic@linux.vnet.ibm.com, joel@jms.id.au, andrew@aj.id.au, "Edward A. James" <eajames@us.ibm.com>
X-Original-Date	Sun, 9 Jul 2017 20:24:13 -0500
X-Original-Message-ID	<20170710012413.g3jhgby6x3m2eznx@rob-hp-laptop>
X-Original-References	<1499290617-2598-1-git-send-email-eajames@linux.vnet.ibm.com> <1499290617-2598-6-git-send-email-eajames@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1683883

Show key headers only | View raw

On Wed, Jul 05, 2017 at 04:36:57PM -0500, Eddie James wrote:
> From: "Edward A. James" <eajames@us.ibm.com>

"dt-bindings: fsi: ..." for the subject.

> 
> Document the bindings for the SBE and OCC devices. SBE devices are
> located on a CFAM on an FSI bus, and OCC devices are accessed through
> the SBEFIFO.
> 
> Signed-off-by: Edward A. James <eajames@us.ibm.com>
> ---
>  Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt | 15 +++++++++++++++
>  .../devicetree/bindings/fsi/ibm,p9-sbefifo.txt       | 20 ++++++++++++++++++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
>  create mode 100644 Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> 
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> new file mode 100644
> index 0000000..766b706
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-occ.txt
> @@ -0,0 +1,15 @@
> +Device-tree bindings for FSI-based On-Chip Controller driver
> +------------------------------------------------------------

Bindings are for h/w, not drivers.

> +
> +Required properties:
> + - compatible = "ibm,p9-occ";
> +
> +Optional properties:
> + - reg = <processor index>;	: Index for the processor this OCC is on.
> +
> +Examples:
> +
> +    occ@1 {
> +        compatible = "ibm,p9-occ";
> +        reg = <1>;
> +    };
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> new file mode 100644
> index 0000000..d16ab9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,p9-sbefifo.txt
> @@ -0,0 +1,20 @@
> +Device-tree bindings for FSI-based SBEFIFO driver
> +-------------------------------------------------

Bindings are for h/w, not drivers.

> +
> +Required properties:
> + - reg = < address size >		: FSI CFAM address for the SBE engine
> +					  and address space size.
> +
> +Optional properties:
> + - <child nodes>			: Devices that are accessible through
> +					  the SBEFIFO.
> +
> +Examples:
> +
> +    sbefifo@2400 {

This should have a compatible.

> +        reg = < 0x2400 0x400 >;
> +
> +        occ@1 {
> +            ...
> +        };
> +    };
> -- 
> 1.8.3.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device documentation Eddie James <eajames@linux.vnet.ibm.com> - 2017-07-05 23:40 +0200
  Re: [PATCH v2 5/5] Documentation/devicetree/bindings: Add FSI device  documentation Rob Herring <robh@kernel.org> - 2017-07-10 03:30 +0200

csiph-web