Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral
Date	Sun, 09 Jul 2017 21:40:01 +0200
Message-ID	<u1qdH-3o7-7@gated-at.bofh.it> (permalink)
References	<tItc6-2GL-11@gated-at.bofh.it> <tIyls-6r1-13@gated-at.bofh.it> <tIyEN-6zR-1@gated-at.bofh.it> <tIzrb-7No-5@gated-at.bofh.it> <tIAng-8so-7@gated-at.bofh.it> <tIC5H-19r-1@gated-at.bofh.it> <tKesi-1hY-11@gated-at.bofh.it> <tPjhF-6Wc-25@gated-at.bofh.it> <tYTOV-7f4-5@gated-at.bofh.it> <u1nzc-1ER-25@gated-at.bofh.it> <u1obU-29o-7@gated-at.bofh.it>
X-Original-To	Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=iIgpx9FrxIoVldj+tCZVLAVEDiWPvflR47pHb2Uptag=; b=pt8RwdpHwSv4Vd5HH8csKMfdDaslQNCCZPHEls6WKGrMVHYLZo1CpEwrC+mfoICCFQ 70HJJ8CgYqtjF0PR5hnJvU27PkkQ0WqfnLs7C3d/pvJAicOONsL3k7Y/8J5UevQWXN3R sM+tQsbEdG5yDAjrzoBhvdVIufCkUizGlhqBwm7WrOb2/IH0PQUy9Mjz2p9Um9sRGvhU /EI10haEmvdWGug3EdOuTl+9qKHHi68CTM7ijkv23JuuYKcvvJLvSL3IBNqgci00+RYE /vGzY3uWGLx0wtdxN7CsxhV7UPlKiqtOoYRM5RhF/X0jUIWdVGD0fVMo0mj20hTzpW27 0H5A==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=iIgpx9FrxIoVldj+tCZVLAVEDiWPvflR47pHb2Uptag=; b=Iv2ohWPCkyqP1J7XRUMrNksRMFhUWOygpGuNzBwk96HqPfYE2ttyq4Qd6oAIhZf0aE AWDLhw58uHIBkMCOHtsDGhiXB1u2iR5po9ouG7QbAsYNwYOIUiPhZ2twtbz5VgU0D+x4 k34sYpZIT9C8PNEff94CWyW5b2DytLLpVzSEU/J2WxoqzPPEnfkoHQ0NxuNp/4A6Cl5t IZ1gfPNKBuOuIH1o6czFD8qVRt6KZgIlej/VPEjgtk+gdrl+9CHBEs3FXIAtB5p8jB0T XfuCnkjzOniMVQJQid42e8HerCJ2XAeAnZ6+4vzReEAzb68mJdbUihhFPTLPxufThShh 96Lw==
X-Gm-Message-State	AIVw11113AtzFd8KBCSlE7pn37iDm6FNjkcFd8ihTsFBBu543UASQozr cTHDXjG5kbLS5RoD8Om321sFBKWsUw==
X-Received	by 10.36.139.197 with SMTP id g188mr8661633ite.108.1499629093219; Sun, 09 Jul 2017 12:38:13 -0700 (PDT)
MIME-Version	1.0
X-Google-Sender-Auth	E707nRhWdTYQkdc5RrNPpFZlMPc
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Sun, 9 Jul 2017 21:38:11 +0200
X-Original-Message-ID	<CAMuHMdX13Dx=xMwWUpyhFZ25HT9h4R5GW314iYBZgy6VCuxmng@mail.gmail.com>
X-Original-References	<1495112345-24795-1-git-send-email-geert+renesas@glider.be> <f0ed61c3-062b-cec6-fe19-7412231e8ef1@gmail.com> <CAMuHMdWYeSzofU57LmT_M3KkcHhvjfJy7nkHvcXkKzOYmvhqqA@mail.gmail.com> <20170518193453.GB13759@lunn.ch> <CAMuHMdV+jfh=EGt3SvjtrtVfWQ6P8ofp_JxeQZjRrSEfDWs5hA@mail.gmail.com> <08a89dd5-b707-8b8f-b8e1-e20b9ed630b7@gmail.com> <CAMuHMdWWfaP8=H7H+UzrmOYpydi2mGLFGzuk9FQWJtEOug6u5g@mail.gmail.com> <CAMuHMdUt6yOQ9=02z_7WG58YGxFYD=_zn7SeLEqGmfTrNBFJXw@mail.gmail.com> <CAMuHMdW8yzREzTE4GiW_8HU9h-T-fdDmLtZAXYkJrjuypN8BDg@mail.gmail.com> <38cc7c65-e4ca-cb8a-f43b-ca53e87724cf@gmail.com> <20170709172815.GA28183@lunn.ch>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1683827

Show key headers only | View raw

Hi Florian, Andrew,

On Sun, Jul 9, 2017 at 7:28 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>> It sure does fix a real issue, but I am really concerned about the
>> inability to test this patch in a configuration where we have multiple
>> PHY(s) or MDIO device(s) hanging off the same MDIO bus and one of those
>> requesting an EPROBE_DEFER.

If that case happens now, it silently falls back to polling, hiding the
problem.

Actually it means there may be users that rely on this broken behavior,
that start to fail when their interrupts are suddenly handled :-(

>> I currently don't have a setup where I could exercise this, Andrew, do you?
>
> What i do have, is a switch with some built in copper Marvell PHYs and
> external SFF modules which use fixed link. I can probably hack the
> fixed-link driver to return EPROBE_DEFER a few times.

That would be great, thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral Florian Fainelli <f.fainelli@gmail.com> - 2017-07-09 18:50 +0200
  Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral Andrew Lunn <andrew@lunn.ch> - 2017-07-09 19:30 +0200
    Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-09 21:40 +0200

csiph-web