Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1683823

Re: [GIT] Networking

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [GIT] Networking
Date 2017-07-09 21:00 +0200
Message-ID <u1pAZ-2UI-15@gated-at.bofh.it> (permalink)
References <u0VjA-11F-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jul 8, 2017 at 3:36 AM, David Miller <davem@davemloft.net> wrote:
>
> 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan.  Also
>    add a WARN_ON() to sock_graft() so other protocol stacks don't trip
>    over this as well.

Hmm. This one triggers for me on both my desktop and laptop at bootup.
Bog-standard machines, running F25 and F24 respectively.

The warning doesn't seem particularly useful, although maybe that
"alg_accept()" gives people who know this code enough of a clue.

                       Linus

------------[ cut here ]------------
WARNING: CPU: 1 PID: 492 at ./include/net/sock.h:1700 af_alg_accept+0x1bf/0x1f0
CPU: 1 PID: 492 Comm: systemd-cryptse Not tainted 4.12.0-09010-g2b976203417c #1
Hardware name: System manufacturer System Product Name/Z170-K, BIOS
1803 05/06/2016
RIP: 0010:af_alg_accept+0x1bf/0x1f0
Call Trace:
 alg_accept+0x15/0x20
 SYSC_accept4+0x105/0x210
 ? getnstimeofday64+0xe/0x20
 ? __audit_syscall_entry+0xb1/0xf0
 ? syscall_trace_enter+0x1bd/0x2d0
 ? __audit_syscall_exit+0x1a5/0x2a0
 SyS_accept+0x10/0x20
 do_syscall_64+0x61/0x140
 entry_SYSCALL64_slow_path+0x25/0x25
---[ end trace a35e5baea85df269 ]---

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT] Networking David Miller <davem@davemloft.net> - 2017-07-08 12:40 +0200
  Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-09 21:00 +0200
    Re: [GIT] Networking Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-07-09 21:20 +0200
      Re: [GIT] Networking David Miller <davem@davemloft.net> - 2017-07-09 22:50 +0200
        Re: [GIT] Networking Herbert Xu <herbert@gondor.apana.org.au> - 2017-07-10 12:10 +0200
          Re: [GIT] Networking Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2017-07-10 14:20 +0200
            Re: [GIT] Networking Herbert Xu <herbert@gondor.apana.org.au> - 2017-07-10 16:10 +0200
              Re: [GIT] Networking David Miller <davem@davemloft.net> - 2017-07-11 22:40 +0200
                Re: [GIT] Networking Herbert Xu <herbert@gondor.apana.org.au> - 2017-07-12 03:50 +0200

csiph-web