Re: [GIT pull] smp/hotplug updates for 4.13

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [GIT pull] smp/hotplug updates for 4.13
Date	2017-07-11 08:10 +0200
Message-ID	<u1WwV-74G-13@gated-at.bofh.it> (permalink)
References	<u1go1-5LI-1@gated-at.bofh.it> <u1oYh-2Hv-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, 9 Jul 2017, Linus Torvalds wrote:
> On Sun, Jul 9, 2017 at 2:07 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > +       /* Wait for the CPU to reach CPUHP_AP_ONLINE_IDLE */
> >         wait_for_completion(&st->done);
> > +       BUG_ON(!cpu_online(cpu));
> 
> I realize this isn't actually a new BUG_ON(), just a moved one, but
> can we *please* just agree to get rid of these machine-killing
> idiocies?
> 
> The fact that it would be a bug if this triggers doesn't excuse it one
> whit. BUG_ON() is simply bad.
> 
> Either it's a "this cannot happen", in which case it should be
> deleted, or it's a "if this ever happens, we really should notice it",
> in which case it should probably be a
> 
>    if (WARN_ON)ONCE(..))
>       return -EBUSY;
> 
> or something.
> 
> That routine very much has an existing error path for failure to bring
> up a CPU, dammit!
> 
> THERE IS NO EXCUSE FOR KILLING THE MACHINE THERE!

Agreed. I noticed when I moved the code, but then forgot. Will queue a fix.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[GIT pull] smp/hotplug updates for 4.13 Thomas Gleixner <tglx@linutronix.de> - 2017-07-09 11:10 +0200
  Re: [GIT pull] smp/hotplug updates for 4.13 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-09 20:20 +0200
    Re: [GIT pull] smp/hotplug updates for 4.13 Thomas Gleixner <tglx@linutronix.de> - 2017-07-11 08:10 +0200

csiph-web