[PATCH V3 2/4] spmi: pmic-arb: fix a possible null pointer dereference

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Kiran Gunda <kgunda@codeaurora.org>
Newsgroups	linux.kernel
Subject	[PATCH V3 2/4] spmi: pmic-arb: fix a possible null pointer dereference
Date	Tue, 11 Jul 2017 03:50:01 +0200
Message-ID	<u1Stj-4eo-3@gated-at.bofh.it> (permalink)
References	<u1Stj-4eo-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1499737530; bh=mNb21XmVtUWPOboot/o6V/oJT/PHlBwgVdfsf//FNTU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V8+kvzU5wSOKZaf3kNvcqgQClcacryK/3TTDBcEKM9kEUgTBYPSZS006F0PcF0KZ/ /pJHfoeLQeGue4MTH2dWCCIE/Xo8nC1JSz/Q8QOb3ACfJf7xCR/6hKGixJVESshWgN cdjaqJBqpqUe97ZG6N7o4pd9m29bm0IxmD1FWvYA=
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1499737529; bh=mNb21XmVtUWPOboot/o6V/oJT/PHlBwgVdfsf//FNTU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MhQvtyVQTY4mnx8+1nRMQQsCunKbBlAg6VrvQUD51vEKKGiZuY8fiRfVkaquVZLAo OfTVGQJIJjHXEZHZM3ta2Uc0D8efpoq+ZlG7lUR8FXnIJI2XGMknzBKhY44TGwcoth JCjrVFYlGzBUE4WSlOr04rLybFxAj5K+p/Q9w7ek=
Dmarc-Filter	OpenDMARC Filter v1.3.2 smtp.codeaurora.org A5E9461387
Authentication-Results	pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results	pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kgunda@codeaurora.org
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-msm@vger.kernel.org
X-Original-Date	Tue, 11 Jul 2017 07:14:55 +0530
X-Original-Message-ID	<1499737497-25649-3-git-send-email-kgunda@codeaurora.org>
X-Original-References	<1499737497-25649-1-git-send-email-kgunda@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1684717

Show key headers only | View raw

If "core" memory resource is not specified, then the driver could
end up dereferencing a null pointer. Fix this issue.

Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 4853758..c7b54a6 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -956,14 +956,14 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev)
 	pmic_arb->spmic = ctrl;
 
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "core");
-	pmic_arb->core_size = resource_size(res);
-
 	core = devm_ioremap_resource(&ctrl->dev, res);
 	if (IS_ERR(core)) {
 		err = PTR_ERR(core);
 		goto err_put_ctrl;
 	}
 
+	pmic_arb->core_size = resource_size(res);
+
 	pmic_arb->ppid_to_apid = devm_kcalloc(&ctrl->dev, PMIC_ARB_MAX_PPID,
 					      sizeof(*pmic_arb->ppid_to_apid),
 					      GFP_KERNEL);
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
 a Linux Foundation Collaborative Project

Thread

[PATCH V3 0/4]: spmi: pmic-arb: support for V5 HW and bug fixes Kiran Gunda <kgunda@codeaurora.org> - 2017-07-11 03:50 +0200
  [PATCH V3 2/4] spmi: pmic-arb: fix a possible null pointer dereference Kiran Gunda <kgunda@codeaurora.org> - 2017-07-11 03:50 +0200
  [PATCH V3 3/4] spmi: pmic-arb: add support for HW version 5 Kiran Gunda <kgunda@codeaurora.org> - 2017-07-11 03:50 +0200
    Re: [PATCH V3 3/4] spmi: pmic-arb: add support for HW version 5 Stephen Boyd <sboyd@codeaurora.org> - 2017-07-14 19:40 +0200
      Re: [PATCH V3 3/4] spmi: pmic-arb: add support for HW version 5 kgunda@codeaurora.org - 2017-07-18 07:10 +0200
  [PATCH V3 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda <kgunda@codeaurora.org> - 2017-07-11 03:50 +0200
  [PATCH V3 1/4] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda <kgunda@codeaurora.org> - 2017-07-11 03:50 +0200

csiph-web