Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684713

Re: [PATCH] dma: k3dma: Fix non-cyclic mode

Show all headers | View raw

On 2017年07月11日 04:53, John Stultz wrote:
> From: Antonio Borneo <borneo.antonio@gmail.com>
>
> Commit 36387a2b1f62b5c087c5fe6f0f7b23b94f722ad7 ("k3dma: Fix
> memory handling in preparation for cyclic mode") broke the
> logic around ds_run/ds_done in case of non-cyclic DMA.
>
> This went unnoticed as the only user of k3dma was the i2s
> audio driver, but with a patch set to enable dma on SPI,
> the issue cropped up.
>
> This patch resolves the issue by reverting part of the
> problematic commit.
>
> This patch has been tested to ensure both audio playback and SPI
> works fine using DMA and that no memory leak is present.
>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
> [jstultz: Expanded commit message a bit]
> Signed-off-by: John Stultz <john.stultz@linaro.org>

Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>

Thanks

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dma: k3dma: Fix non-cyclic mode John Stultz <john.stultz@linaro.org> - 2017-07-10 23:00 +0200
  Re: [PATCH] dma: k3dma: Fix non-cyclic mode zhangfei <zhangfei.gao@linaro.org> - 2017-07-11 03:20 +0200

csiph-web