Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684704
| From | Evgeny Baskakov <ebaskakov@nvidia.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 |
| Date | 2017-07-11 02:20 +0200 |
| Message-ID | <u1R4e-3wG-5@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <tWMeR-X0-3@gated-at.bofh.it> <tYdmF-3lY-3@gated-at.bofh.it> <tYeVr-4aS-11@gated-at.bofh.it> <u1POO-2A7-5@gated-at.bofh.it> <u1QBc-38v-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 7/10/17 4:43 PM, Jerome Glisse wrote:
> On Mon, Jul 10, 2017 at 03:59:37PM -0700, Evgeny Baskakov wrote:
> ...
> Horrible stupid bug in the code, most likely from cut and paste. Attached
> patch should fix it. I don't know how long it took for you to trigger it.
>
> Jérôme
Thanks, this indeed fixes the problem! Yes, it took a nightly run before
it triggered.
One a side note, should this "return NULL" be replaced with "return
ERR_PTR(-ENOMEM)"?
struct hmm_device *hmm_device_new(void *drvdata)
{
...
if (hmm_device->minor >= HMM_DEVICE_MAX) {
spin_unlock(&hmm_device_lock);
kfree(hmm_device);
-> return NULL;
}
Thanks!
Evgeny Baskakov
NVIDIA
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 Evgeny Baskakov <ebaskakov@nvidia.com> - 2017-07-11 01:00 +0200
Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 Jerome Glisse <jglisse@redhat.com> - 2017-07-11 01:50 +0200
Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 Evgeny Baskakov <ebaskakov@nvidia.com> - 2017-07-11 02:20 +0200
Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 Jerome Glisse <jglisse@redhat.com> - 2017-07-11 03:00 +0200
csiph-web