Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684649
| From | Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition |
| Date | 2017-07-10 23:30 +0200 |
| Message-ID | <u1OpI-1Qy-27@gated-at.bofh.it> (permalink) |
| References | <u1IaB-6eJ-5@gated-at.bofh.it> <u1LUS-cs-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jul 10, 2017 at 08:43:12PM +0200, Christian Borntraeger wrote:
> On 07/10/2017 04:44 PM, Gleb Fotengauer-Malinovskiy wrote:
> > This ioctl actually writes to parameter too.
>
> Maybe rephrase that to:
> The kernel does not only read struct kvm_s390_cmma_log for KVM_S390_GET_CMMA_BITS,
> it also writes back a return value making this _IOWR instead of _IOW.
Ok, see v2.
> > Fixes: 4036e387 ("KVM: s390: ioctls to get and set guest storage attributes")
> > Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
>
> Out of curiosity, how did you notice that?
I regenerated strace's ioctl lists. It was obvious from the diff that
*GET* and *SET* could not be both _IOC_WRITE.
--
glebfm
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-07-10 16:50 +0200
Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Christian Borntraeger <borntraeger@de.ibm.com> - 2017-07-10 20:50 +0200
Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-07-10 23:30 +0200
Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Christian Borntraeger <borntraeger@de.ibm.com> - 2017-07-11 10:30 +0200
Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Radim Krčmář <rkrcmar@redhat.com> - 2017-07-11 16:30 +0200
[PATCH v2] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org> - 2017-07-10 23:30 +0200
csiph-web