Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684598
| From | Alan Ott <alan@signal11.us> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] mrf24j40: Fix en error handling path in 'mrf24j40_probe()' |
| Date | 2017-07-10 21:30 +0200 |
| Message-ID | <u1MxA-Ey-17@gated-at.bofh.it> (permalink) |
| References | <u0TB7-8kI-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/08/2017 04:40 AM, Christophe JAILLET wrote:
> If this check fails, we must release some resources as done everywhere
> else in this function before returning an error code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> V2: initialization of ret in this erro path ws missing. Stupid me!
> ---
> drivers/net/ieee802154/mrf24j40.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index 7d334963dc08..da8683782ffc 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -1330,7 +1330,8 @@ static int mrf24j40_probe(struct spi_device *spi)
> if (spi->max_speed_hz > MAX_SPI_SPEED_HZ) {
> dev_warn(&spi->dev, "spi clock above possible maximum: %d",
> MAX_SPI_SPEED_HZ);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto err_register_device;
> }
>
> ret = mrf24j40_hw_init(devrec);
>
Acked-by: Alan Ott <alan@signal11.us>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] mrf24j40: Fix en error handling path in 'mrf24j40_probe()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-07-08 10:50 +0200 Re: [PATCH v2] mrf24j40: Fix en error handling path in 'mrf24j40_probe()' Alan Ott <alan@signal11.us> - 2017-07-10 21:30 +0200 Re: [PATCH v2] mrf24j40: Fix en error handling path in 'mrf24j40_probe()' Marcel Holtmann <marcel@holtmann.org> - 2017-07-11 08:50 +0200
csiph-web