Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly
Date	2017-07-10 20:40 +0200
Message-ID	<u1LLd-94-43@gated-at.bofh.it> (permalink)
References	<u1DkC-3e1-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 10 Jul 2017 11:37:51 +0200

> The new IPSec offload code introduced a build error:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.o: In function `mlx5e_ipsec_build_inverse_table':
> ipsec_rxtx.c:(.text+0x556): undefined reference
> 
> Another patch was added on top to fix the build error, but
> that introduced a new bug, as we now use the remainder of
> the division rather than the result.
> 
> This makes it use the correct helper function instead.
> 
> Fixes: 5dfd87b67cd9 ("net/mlx5: IPSec, Fix 64-bit division on 32-bit builds")
> Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data path")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net/mlx5: IPSec, fix 64-bit division correctly Arnd Bergmann <arnd@arndb.de> - 2017-07-10 11:40 +0200
  RE: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly Ilan Tayari <ilant@mellanox.com> - 2017-07-10 12:00 +0200
  RE: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly Ilan Tayari <ilant@mellanox.com> - 2017-07-10 12:30 +0200
    Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly Joe Perches <joe@perches.com> - 2017-07-10 17:50 +0200
  Re: [PATCH] net/mlx5: IPSec, fix 64-bit division correctly David Miller <davem@davemloft.net> - 2017-07-10 20:40 +0200

csiph-web