Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1684563

Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings
Date 2017-07-10 20:40 +0200
Message-ID <u1LLc-94-11@gated-at.bofh.it> (permalink)
References <tX1dU-2UD-23@gated-at.bofh.it> <tXqP0-1wb-11@gated-at.bofh.it> <tY83E-8nx-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Fri, Jun 30, 2017 at 11:08:15PM +0530, Aravind Thokala wrote:
> Hello Mark,

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> These warnings looked straightforward for me so I've fixed those and
> sent the patch.

> Kindly let me know if you want to record the warnings in the patch so
> that I could send v2 patch as soon as possible.

It's not just a case of quoting the warnings, it's a case of explaining
what your patch changes which usually requires more than just quoting
the warning.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Mark Brown <broonie@kernel.org> - 2017-07-10 20:40 +0200

csiph-web