Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684535

Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 2017-07-10 14:09, Mark Brown wrote:
> On Sun, Jul 09, 2017 at 12:48:10AM +0300, Andy Shevchenko wrote:
>> On Sat, Jul 8, 2017 at 11:41 AM, Jan Kiszka <jan.kiszka@web.de> wrote:
> 
>>> Tested on the IOT2000 where the second SPI bus is connected to an
>>> Arduino-compatible connector and multiplexed between SPI, GPIO and PWM
>>> usage.
> 
>> Can we first switch the driver to use GPIO descriptors instead of
>> plain integers?
> 
> Only if you also convert the SPI core to use descriptors, Chris Packham
> was looking at that but he needed update the ep93xx drivers among others
> and getting reviewers was hard.
> 

IIUC, we can't convert completely due to some legacy boards providing
their CS lines as integers. But even then, a few more API usages can be
converted.

While looking into this, I noticed that this patch violated the formal
rule to never release a GPIO with the old API when it was requested with
the new one. That's at least stated in the docs, even though gpio_free
is equivalent to gpiod_put. Fixed that already, but I need to find some
time to retest.

Jan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is  created Jan Kiszka <jan.kiszka@web.de> - 2017-07-08 10:50 +0200
  Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-08 23:50 +0200
    Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is  created Jan Kiszka <jan.kiszka@web.de> - 2017-07-09 11:40 +0200
      Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-09 12:00 +0200
        Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is  created Jan Kiszka <jan.kiszka@web.de> - 2017-07-09 12:40 +0200
    Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device  is created Mark Brown <broonie@kernel.org> - 2017-07-10 14:10 +0200
      Re: [PATCH] spi: pxa2xx: Only claim CS GPIOs when the slave device is  created Jan Kiszka <jan.kiszka@web.de> - 2017-07-10 19:40 +0200
  Applied "spi: pxa2xx: Only claim CS GPIOs when the slave device is created" to the spi tree Mark Brown <broonie@kernel.org> - 2017-07-17 18:10 +0200

csiph-web