Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684370
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] binfmt_flat: fix format string for u32 |
| Date | 2017-07-10 17:50 +0200 |
| Message-ID | <u1J6H-6RW-33@gated-at.bofh.it> (permalink) |
| References | <u1EJH-4h6-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2017-07-10 at 13:08 +0200, Arnd Bergmann wrote:
> The types have changed from 'unsigned long' to 'u32', so now the
> format string is wrong, and produces a harmless warning on arm32:
[]
> This changes it to '%d' instead, matching the 'u32' type.
[]
> diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
[]
> @@ -574,7 +574,7 @@ static int load_flat_file(struct linux_binprm *bprm,
> MAX_SHARED_LIBS * sizeof(unsigned long),
> FLAT_DATA_ALIGN);
>
> - pr_debug("Allocated data+bss+stack (%ld bytes): %lx\n",
> + pr_debug("Allocated data+bss+stack (%d bytes): %lx\n",
> data_len + bss_len + stack_len, datapos);
Ideally, %u not %d as data_len, bss_len and stack_len are all u32
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] binfmt_flat: fix format string for u32 Arnd Bergmann <arnd@arndb.de> - 2017-07-10 13:10 +0200 Re: [PATCH] binfmt_flat: fix format string for u32 Joe Perches <joe@perches.com> - 2017-07-10 17:50 +0200
csiph-web