Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684358

Re: [PATCH] char/mwave: make some arrays static const to make object code smaller

Show all headers | View raw

On 10/07/17 16:28, Arnd Bergmann wrote:
> On Mon, Jul 10, 2017 at 5:08 PM, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate arrays on the stack but make them static.  Makes
>> the object code smaller.  Also remove temporary variables that
>> have hard coded array sizes and just use ARRAY_SIZE instead and
>> wrap some lines that are wider than 80 chars to clean up some
>> checkpatch warnings.
>>
>> Before:
>>    text    data     bss     dec     hex filename
>>   11141    2008      64   13213    339d drivers/char/mwave/smapi.o
>>
>> After:
>>    text    data     bss     dec     hex filename
>>   10697    2352      64   13113    3339 drivers/char/mwave/smapi.o
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
> Did you use a particular tool that found these variables?

I'm using some grep foo and some targeted eyeballing.

> 
> I assume you are not actually using the driver ;-)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] char/mwave: make some arrays static const to make object code smaller Colin King <colin.king@canonical.com> - 2017-07-10 17:10 +0200
  Re: [PATCH] char/mwave: make some arrays static const to make object  code smaller Arnd Bergmann <arnd@arndb.de> - 2017-07-10 17:30 +0200
    Re: [PATCH] char/mwave: make some arrays static const to make object  code smaller Colin Ian King <colin.king@canonical.com> - 2017-07-10 17:40 +0200

csiph-web