Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX
Date	2017-07-10 17:30 +0200
Message-ID	<u1INk-6L7-17@gated-at.bofh.it> (permalink)
References	<tUv8u-37f-21@gated-at.bofh.it> <tUv8v-37f-35@gated-at.bofh.it> <tVEMp-7yC-1@gated-at.bofh.it> <tWFn3-4Lf-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jun 26, 2017 at 11:42 AM, Jose Abreu <Jose.Abreu@synopsys.com> wrote:
> Hi Rob,
>
>
> On 23-06-2017 22:58, Rob Herring wrote:
>> On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote:
>>> Document the bindings for the Synopsys Designware HDMI RX.
>>>

[...]

>>> +A sample binding is now provided. The compatible string is for a SoC which has
>>> +has a Synopsys Designware HDMI RX decoder inside.
>>> +
>>> +Example:
>>> +
>>> +dw_hdmi_soc: dw-hdmi-soc@0 {
>>> +    compatible = "snps,dw-hdmi-soc";
>> Not documented.
>
> Yes, its a sample binding which reflects a wrapper driver that
> shall instantiate the controller driver (and this wrapper driver
> is not in this patch series), should I remove this?

Ah, I see. Please don't do this wrapper node like what was done on
DWC3. It should be all one node with the SoC specific part being a new
compatible string (and maybe additional properties). If there's really
some custom logic around the IP block, then maybe it makes sense, but
if it is just different clock connections, phys, resets, etc. those
don't need a separate node.

Rob

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware  HDMI RX Rob Herring <robh@kernel.org> - 2017-07-10 17:30 +0200
  Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware  HDMI RX Jose Abreu <Jose.Abreu@synopsys.com> - 2017-07-10 18:00 +0200

csiph-web