Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684211
| From | Johan Hovold <johan@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices |
| Date | 2017-07-10 15:00 +0200 |
| Message-ID | <u1Gsa-5a4-23@gated-at.bofh.it> (permalink) |
| References | <u0lSN-2dT-1@gated-at.bofh.it> <u0lSO-2dT-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jul 06, 2017 at 10:49:16PM +0200, Anatolij Gustschin wrote:
> Add USB part with common functions for USB-GPIO/I2C/SPI master
> adapters. These allow communication with chip's control, transmit
> and receive endpoints and will be used by various FT232H drivers.
> +static const struct mfd_cell ftdi_cells[] = {
> + { .name = "ftdi-cbus-gpio", },
> + { .name = "ftdi-mpsse-i2c", },
> + { .name = "ftdi-mpsse-spi", },
> + { .name = "ftdi-fifo-fpp-mgr", },
> +};
Correct me if I'm wrong, but aren't these modes really mutually
exclusive, possibly with exception of cbus-gpio (some pins are at least
available as GPIOs in MPSSE mode)? Then MFD is not is not the right fit
here either.
And as David Laight already pointed out, your ftdi-fifo-fpp-mgr driver
seems too application specific for a generic chip like this.
Johan
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] FPGA Manager support for FPP via FT232H FT245-FIFO Anatolij Gustschin <agust@denx.de> - 2017-07-06 22:50 +0200
[PATCH 1/3] mfd: Add support for FTDI FT232H devices Anatolij Gustschin <agust@denx.de> - 2017-07-06 22:50 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Bjørn Mork <bjorn@mork.no> - 2017-07-07 09:50 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Anatolij Gustschin <agust@denx.de> - 2017-07-07 12:00 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Johan Hovold <johan@kernel.org> - 2017-07-10 14:40 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Anatolij Gustschin <agust@denx.de> - 2017-07-11 09:00 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Johan Hovold <johan@kernel.org> - 2017-07-12 11:00 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Bjørn Mork <bjorn@mork.no> - 2017-07-12 11:20 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Anatolij Gustschin <agust@denx.de> - 2017-07-13 18:40 +0200
Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices Johan Hovold <johan@kernel.org> - 2017-07-10 15:00 +0200
[PATCH 2/3] gpio: Add FT232H CBUS GPIO driver Anatolij Gustschin <agust@denx.de> - 2017-07-06 22:50 +0200
[PATCH 3/3] fpga manager: Add FT232H driver for Altera FPP Anatolij Gustschin <agust@denx.de> - 2017-07-06 23:00 +0200
RE: [PATCH 3/3] fpga manager: Add FT232H driver for Altera FPP David Laight <David.Laight@ACULAB.COM> - 2017-07-07 11:40 +0200
csiph-web