Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684075

Re: [PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup scripts/Makefile.headersinst

Show all headers | View raw

Hi Sam,


2017-07-10 17:42 GMT+09:00 Sam Ravnborg <sam@ravnborg.org>:
> Hi Masahiro.
>
> On Mon, Jul 10, 2017 at 03:32:32AM +0900, Masahiro Yamada wrote:
>> In v4.12-rc1, we had a big progress for headers_install.
>> All (and only) headers under UAPI directories are exported.
>> However, asm-generic wrappers are still exceptions because
>> most of arch/*/include/asm/Kbuild include "generic-y" for
>> exported headers.  As a result, many of generic-wrappers to be
>> exported are generated outside UAPI directories.
>>
>> To finish de-coupling UAPI, "generic-y" for exported headers
>> should be moved to arch/*/include/uapi/asm/Kbuild.
>>
>> With those cleanups, the logic of headers_install will become
>> even simpler.  UAPI will be completely self-contained.
>>
>> This series is based on:
>> commit 19bf2e0ef18ec8a7284ecc83459a2664cb885cd5
>>
>> Changes for v2:
>>   - rebase on the latest in the mainline in order to avoid merge conflicts
>
> Series looks good.
>
> In several of your patches assignments are moved to the arch
> specific uapi file, but the same assignment are already present in
> include/uapi/asm-generic/Kbuild.asm so the assignment is redundant.
>
> For example:
> $ARCH uapi Kbuild:
> generic-y += errno.h
>
> uapi/asm-generic Kbuild:
> mandatory-y += errno.h
>
> As this patch-set is touching all arch files this
> could be a good opportunity to clean this up too.
>
> But maybe mandatory-y and generic-y do something different,
> and both are needed. In wich cases all is good.
>

Thanks for your review, and you have a good point.

If neither arch-own header implementation is found
nor generic-y is specified, the build system can automatically generate
generic wrappers for "mandatory" headers.

I also considered of it, but I wanted to take my time.

I simply moved generic-y without introducing any logical change
in order to make this series less controversial.

One point of forcing explicit generic-y might be,
to give arch maintainers an opportunity to judge
if falling back to asm-generic one works or not.



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup scripts/Makefile.headersinst Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 24/28] unicore32: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 13/28] m32r: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 12/28] ia64: remove redundant generic-y += kvm_para.h from asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 19/28] openrisc: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
    Re: [PATCH v2 19/28] openrisc: move generic-y of exported headers to  uapi/asm/Kbuild Stafford Horne <shorne@gmail.com> - 2017-07-10 22:30 +0200
  [PATCH v2 04/28] arm64: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 23/28] tile: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 09/28] cris: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 14/28] m68k: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 22/28] sparc: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  [PATCH v2 06/28] arc: move generic-y of exported headers to uapi/asm/Kbuild Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-09 20:40 +0200
  Re: [PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup  scripts/Makefile.headersinst Sam Ravnborg <sam@ravnborg.org> - 2017-07-10 10:50 +0200
    Re: [PATCH v2 00/28] kbuild: complete UAPI de-coupling and cleanup scripts/Makefile.headersinst Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-10 11:20 +0200

csiph-web