Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684012

Re: [PATCH] usb: isp1760: compress return logic into one line

From Oliver Neukum <oneukum@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH] usb: isp1760: compress return logic into one line
Date 2017-07-10 09:40 +0200
Message-ID <u1Bst-236-3@gated-at.bofh.it> (permalink)
References <u1wj7-7ix-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb  Gustavo A. R. Silva :
> Simplify return logic to avoid unnecessary variable assignment.
> 
> This issue was detected using Coccinelle and the following
> semantic patch:
> 

Hi,

I need to ask: Where is the improvement? The compiler does not bother
and for the human reader you do not do anything obvious and you
decreased grepability.

	Regards
		Oliver

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: isp1760: compress return logic into one line "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-10 04:10 +0200
  Re: [PATCH] usb: isp1760: compress return logic into one line Oliver Neukum <oneukum@suse.com> - 2017-07-10 09:40 +0200
    Re: [PATCH] usb: isp1760: compress return logic into one line "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-10 22:30 +0200
      Re: [PATCH] usb: isp1760: compress return logic into one line Oliver Neukum <oneukum@suse.com> - 2017-07-11 10:20 +0200

csiph-web