Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1684006

Re: [PATCH] kernel: cpu: hotplug: constify attribute_group structures.

Show all headers | View raw

On 2017-06-29 17:40:47 [+0530], Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   12582	  15361	     20	  27963	   6d3b	kernel/cpu.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>   12710	  15265	     20	  27995	   6d5b	kernel/cpu.o

While there does not seem to be anything wrong with it, why did the file
grow after the patch was applied?

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Sebastian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] kernel: cpu: hotplug: constify attribute_group  structures. Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2017-07-10 09:20 +0200
  Re: [PATCH] kernel: cpu: hotplug: constify attribute_group  structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-10 09:40 +0200

csiph-web