Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1683669
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() |
| Date | Sun, 09 Jul 2017 01:00:01 +0200 |
| Message-ID | <u16RH-87c-9@gated-at.bofh.it> (permalink) |
| References | <u0M6C-3qm-7@gated-at.bofh.it> <u0TKN-8pp-11@gated-at.bofh.it> |
| X-Original-To | Bernd Petrovitsch <bernd@petrovitsch.priv.at> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2yiEVfdRDveCsAGoUtl6LBpOkGl72Sk1sZSeXJEQ9u4=; b=UX68yXPGU7prnsgAxYCfV0FbqpMaCQzcJXds9veVS99B7ES57iA5glx2piQC1qFj6U 05jaD+rVEvnqSMAKIhPTwut2M8nSDVGB/dGpYZA+luGcDQQkXm7YzZMrkDKwLou2leFq rlnRXu1O2n4BZ1o7r23lTfMcbcNEIczOLufYYypEPNib2w6HmtDC2/0Chj0Sq8ysbCGT cLyF6219APWUGbu/CVvP3s3/yW1bWjTIsf9MZ1+0M//nu2imJT0xNdUABTxmzjLe0bjo UaFmAYbQeGSYZhPBiK2K2xCiDxYG2R9PQQ1U+dSHZ4UfPpOzY/Igzl1U2Bn6/qGv9cox OLwA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2yiEVfdRDveCsAGoUtl6LBpOkGl72Sk1sZSeXJEQ9u4=; b=PXxsqZcOGluLlS+pcYQ1bJiKzP8eRofh0MojPTwrQy8VwZlX8FaXd3MbPC1x8RSQwK QtVNtqt++grIME2FWg0x3sUqBHEY7YXG7CcG3OA4IyoQMVcejwQRooL+rbbM0TgpOnLK PdXmTrcTPtDoDCyzz7IkscnEh0/NFt/XDmHZAiZU6uisa8YlPwmgx4iKMpBsDa3p8tk9 ZPZ1rI3HfWwBgfGr/Yln9fcel6oauLjAAAlD/loCUBE/4beI0D/3KzB/W2T/JxBX/xjG rjppnhgXCdXbdztz2hTYD22AOst6cqtWVfUdxvwy+HeJY2gxlY0BmUxSANIomBOnJ0nk SdnA== |
| X-Gm-Message-State | AIVw113i/35kWj0FVcViseMN8oZwatE2VYERbj2FHaPtzgqZfyT31kGT 3/uWJGQzbKrRUbGTcZCsxLxwOzciEQ== |
| X-Received | by 10.107.169.211 with SMTP id f80mr15074525ioj.153.1499554548969; Sat, 08 Jul 2017 15:55:48 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="UTF-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 28 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | mchehab@kernel.org, Greg KH <gregkh@linuxfoundation.org>, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Sat, 8 Jul 2017 18:55:48 -0400 |
| X-Original-Message-ID | <CA+5yK5FA3hLctjv-ysEspMveg+_M+JqvsM+UuEj88NTwX=4Sjg@mail.gmail.com> |
| X-Original-References | <20170708004102.GA27161@amitoj-Inspiron-3542> <1499504311.3472.13.camel@petrovitsch.priv.at> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1683669 |
Show key headers only | View raw
On Sat, Jul 8, 2017 at 4:58 AM, Bernd Petrovitsch
<bernd@petrovitsch.priv.at> wrote:
> On Fri, 2017-07-07 at 20:41 -0400, Amitoj Kaur Chawla wrote:
> [...]
>> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
>> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
>> @@ -117,11 +117,7 @@ void *atomisp_kernel_zalloc(size_t bytes, bool
>> zero_mem)
>> */
>> void atomisp_kernel_free(void *ptr)
>> {
>> - /* Verify if buffer was allocated by vmalloc() or kmalloc()
>> */
>> - if (is_vmalloc_addr(ptr))
>> - vfree(ptr);
>> - else
>> - kfree(ptr);
>> + kvfree(ptr);
>> }
>>
>> /*
>
> Why not get rid of the trivial wrapper function completely?
>
Oh yes, i'll send a v2.
Amitoj
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2017-07-08 02:50 +0200
Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() Bernd Petrovitsch <bernd@petrovitsch.priv.at> - 2017-07-08 11:00 +0200
Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2017-07-09 01:00 +0200
csiph-web