Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1683640
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Christos Gkekas <chris.gekas@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify. |
| Date | Sat, 08 Jul 2017 21:30:01 +0200 |
| Message-ID | <u13At-69U-1@gated-at.bofh.it> (permalink) |
| X-Original-To | Joe Perches <joe@perches.com>, Jiri Kosina <jikos@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cXV15GE/NuZp9kHcf+c/KmPvu7bq9daq7NPH9zYtx+Q=; b=AwfcgfL8rHjZp9ohdoSkLmIFni0Witrxs829f9N7IhngG/L2sIONgR8umwT9lla7oD MJSm5C3hk20RX+/aDvsPXF5qtgRLTlRPJe+akGj2ZB/Z6QH+vObXEceCjMVlLhgfWPoO vS0fL1MU69Q/2sBKn5Y8MyOluUXw9sDnAgRYyGbn+/D3vUzrUnkHT3CZN2k2wUqRXLNn 4oeOk4v4nZMKxnqrEqStZ6wZvVCnvZh0FHPYGnY4sfSasY6t0fI1sHlHOh8uJ7T5aRkF Qwb1GeAZ0Kx9VnATXGGuxmLElAbmtiK05uLamEDGlqUFjK+3zPtkw821wcv1HLLIPiHO q17w== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cXV15GE/NuZp9kHcf+c/KmPvu7bq9daq7NPH9zYtx+Q=; b=S4efm6j+dUm3AaR7YS0o5+EMDsHwzD1LZxnPS0sDWjfxNIs77O0IXzFHPTfPrf/dll DCzxo0VaLm02Cam9yvi7gJNWbZcQml5xdZS+sRcH//jPyzYYpTY3IPs6kMwgsQ9Qeq2F TgRrSbM54N6ARiAhFdt307QN9QugrOmsgeVUlFmSkbuEvz0P59S3iY2JQkiOjuXOQu2H r3AyxKft5Vziv1I/ivQ4OduAN4/uEBQAyitJGH9naGXLCvoC5F8cA5g7CqWVZM4KixZL xZuPLbvBeda2CdQ8UTBxPQ7dKSbcrCRgBpOsTUDJVD+fWdXIcwqGMYtq0eA6s0VKefDA xx0Q== |
| X-Gm-Message-State | AIVw112lP4+CnXxYAeOdEy2LXNKphciV2BG5ckSvHkfvr+PChEBUs3DG 6v5Qd0IHNsJvnA== |
| X-Received | by 10.223.136.11 with SMTP id d11mr3371041wrd.73.1499541980219; Sat, 08 Jul 2017 12:26:20 -0700 (PDT) |
| X-Mailer | git-send-email 2.7.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Christos Gkekas <chris.gekas@gmail.com> |
| X-Original-Date | Sat, 8 Jul 2017 20:25:48 +0100 |
| X-Original-Message-ID | <1499541948-3392-1-git-send-email-chris.gekas@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1683640 |
Show key headers only | View raw
Variable mode in method wacom_show_remote_mode() is defined as u8, thus statement (mode >= 0) is always true and should be removed, simplifying the logic. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/hid/wacom_sys.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 838c1eb..ae2408d 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -1671,10 +1671,7 @@ static ssize_t wacom_show_remote_mode(struct kobject *kobj, u8 mode; mode = wacom->led.groups[index].select; - if (mode >= 0 && mode < 3) - return snprintf(buf, PAGE_SIZE, "%d\n", mode); - else - return snprintf(buf, PAGE_SIZE, "%d\n", -1); + return sprintf(buf, "%d\n", mode < 3 ? mode : -1); } #define DEVICE_EKR_ATTR_GROUP(SET_ID) \ -- 2.7.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify. Christos Gkekas <chris.gekas@gmail.com> - 2017-07-08 21:30 +0200 Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify. Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-07-12 09:40 +0200
csiph-web