Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683126

[PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration

Show all headers | View raw

When CONFIC_CEC_NOTIFIER is not set and we only include cec-notifier.h
we can get build warnings like these ones:

"warning: ‘struct cec_notifier’ declared inside parameter list will
not be visible outside of this definition or declaration"

Prevent these warnings by using forward declaration of notifier
structure.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Carlos Palminha <palminha@synopsys.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
---
 include/media/cec-notifier.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/media/cec-notifier.h b/include/media/cec-notifier.h
index 298f996..84f9376 100644
--- a/include/media/cec-notifier.h
+++ b/include/media/cec-notifier.h
@@ -21,14 +21,14 @@
 #ifndef LINUX_CEC_NOTIFIER_H
 #define LINUX_CEC_NOTIFIER_H
 
-#include <linux/types.h>
-#include <media/cec.h>
-
 struct device;
 struct edid;
 struct cec_adapter;
 struct cec_notifier;
 
+#include <linux/types.h>
+#include <media/cec.h>
+
 #if IS_REACHABLE(CONFIG_CEC_CORE) && IS_ENABLED(CONFIG_CEC_NOTIFIER)
 
 /**
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings using forward declaration Jose Abreu <Jose.Abreu@synopsys.com> - 2017-07-07 13:10 +0200
  Re: [PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings  using forward declaration Hans Verkuil <hansverk@cisco.com> - 2017-07-07 13:20 +0200
    Re: [PATCH v7 2/6] [media] cec-notifier.h: Prevent build warnings  using forward declaration Jose Abreu <Jose.Abreu@synopsys.com> - 2017-07-07 13:30 +0200

csiph-web