Re: [PATCH 21/21] x86/intel_rdt/mbm: Handle counter overflow

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 21/21] x86/intel_rdt/mbm: Handle counter overflow
Date	2017-07-07 09:00 +0200
Message-ID	<u0vp8-9I-21@gated-at.bofh.it> (permalink)
References	<tWHoR-5Yd-3@gated-at.bofh.it> <tWHoS-5Yd-47@gated-at.bofh.it> <tYNzP-2La-1@gated-at.bofh.it> <u0oQF-43b-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 6 Jul 2017, Shivappa Vikas wrote:
> On Sun, 2 Jul 2017, Thomas Gleixner wrote:
> > On Mon, 26 Jun 2017, Vikas Shivappa wrote:
> > > +static void mbm_update(struct rdt_domain *d, int rmid)
> > > +{
> > > +	struct rmid_read rr;
> > > +
> > > +	rr.first = false;
> > > +	rr.d = d;
> > > +
> > > +	if (is_mbm_total_enabled()) {
> > > +		rr.evtid = QOS_L3_MBM_TOTAL_EVENT_ID;
> > > +		__mon_event_count(rmid, &rr);
> > 
> > This is broken as it is not protected against a concurrent read from user
> > space which comes in via a smp function call.
> 
> The read from user also has the rdtgroup_mutex.

Which is again, completely non obvious and undocumented in the code.

Aside of that, are you really serious about serializing the world and
everything on a single global mutex?

Thanks,

	tglx

Thread

Re: [PATCH 21/21] x86/intel_rdt/mbm: Handle counter overflow Shivappa Vikas <vikas.shivappa@intel.com> - 2017-07-07 02:00 +0200
  Re: [PATCH 21/21] x86/intel_rdt/mbm: Handle counter overflow Thomas Gleixner <tglx@linutronix.de> - 2017-07-07 09:00 +0200
    Re: [PATCH 21/21] x86/intel_rdt/mbm: Handle counter overflow "Luck, Tony" <tony.luck@intel.com> - 2017-07-10 20:00 +0200
      Re: [PATCH 21/21] x86/intel_rdt/mbm: Handle counter overflow Thomas Gleixner <tglx@linutronix.de> - 2017-07-11 17:30 +0200

csiph-web