[PATCH] arcnet: com20020-pci: Fix an error handling path in 'com20020pci_probe()'

From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	[PATCH] arcnet: com20020-pci: Fix an error handling path in 'com20020pci_probe()'
Date	2017-07-07 07:00 +0200
Message-ID	<u0twZ-7l9-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If this memory allocation fails, we should go through the error handling
path as done everywhere else in this function before returning.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/arcnet/com20020-pci.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c
index 239de38fbd6a..8e89a2ac071e 100644
--- a/drivers/net/arcnet/com20020-pci.c
+++ b/drivers/net/arcnet/com20020-pci.c
@@ -196,8 +196,10 @@ static int com20020pci_probe(struct pci_dev *pdev,
 
 		card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev),
 				    GFP_KERNEL);
-		if (!card)
-			return -ENOMEM;
+		if (!card) {
+			ret = -ENOMEM;
+			goto out_port;
+		}
 
 		card->index = i;
 		card->pci_priv = priv;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] arcnet: com20020-pci: Fix an error handling path in 'com20020pci_probe()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-07-07 07:00 +0200
  Re: [PATCH] arcnet: com20020-pci: Fix an error handling path in  'com20020pci_probe()' David Miller <davem@davemloft.net> - 2017-07-07 10:30 +0200

csiph-web