Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682839

Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value

Show all headers | View raw

On 2017年07月07日 05:58, Gustavo A. R. Silva wrote:
> The right variable to check here is port, not dp.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @@
> expression x;
> identifier fld;
> @@
>
> * x = devm_kzalloc(...);
>    ... when != x == NULL
>    x->fld
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Thanks for the fix,

Acked-by: Mark Yao <mark.yao@rock-chips.com>

> ---
>   drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index 14fa1f8..9b0b058 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -1195,7 +1195,7 @@ static int cdn_dp_probe(struct platform_device *pdev)
>   			continue;
>   
>   		port = devm_kzalloc(dev, sizeof(*port), GFP_KERNEL);
> -		if (!dp)
> +		if (!port)
>   			return -ENOMEM;
>   
>   		port->extcon = extcon;


-- 
Ｍark Yao

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-07 00:00 +0200
  Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return  value Mark yao <mark.yao@rock-chips.com> - 2017-07-07 03:00 +0200
    Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return  value Sean Paul <seanpaul@chromium.org> - 2017-07-10 21:10 +0200
      Re: [PATCH] drm/rockchip: fix NULL check on devm_kzalloc() return  value Mark yao <mark.yao@rock-chips.com> - 2017-07-11 02:50 +0200

csiph-web