Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682772

Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file()

Show all headers | View raw

On Mon,  5 Jun 2017 11:31:18 +0200
Federico Vaga <federico.vaga@vaga.pv.it> wrote:

> show_file(name) and show_instance_file(&top_instance, name) are
> equivalent.
> 
> Remove the show_file() function in order to have a single function for
> this task.

Actually I find nothing wrong with having a helper function like this.
IIRC, show_file() was first, and then show_instance_file() came later.
There's some files that only exist for the top_instance, and I like the
fact that this is annotated that way.

I'm curious to know what the benefit of removing show_file() is?

-- Steve


> 
> Signed-off-by: Federico Vaga <federico.vaga@vaga.pv.it>
> ---
>  trace-list.c     | 21 ++++++---------------
>  trace-local.h    |  2 --
>  trace-show.c     | 18 ++----------------
>  trace-snapshot.c |  2 +-
>  4 files changed, 9 insertions(+), 34 deletions(-)
\

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] trace-cmd: replace show_file() ->  show_instance_file() Steven Rostedt <rostedt@goodmis.org> - 2017-07-07 00:30 +0200
  Re: [PATCH 2/2] trace-cmd: replace show_file() -> show_instance_file() Federico Vaga <federico.vaga@vaga.pv.it> - 2017-07-10 02:20 +0200

csiph-web