Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1682707
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver |
| Date | 2017-07-06 23:00 +0200 |
| Message-ID | <u0m2u-2hh-23@gated-at.bofh.it> (permalink) |
| References | <u0fX4-5RS-15@gated-at.bofh.it> <u0g6K-60R-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Jul 06, 2017 at 10:28:22PM +0800, Icenowy Zheng wrote: > SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 0), > SUNXI_FUNCTION(0x0, "gpio_in"), > SUNXI_FUNCTION(0x1, "gpio_out"), > - SUNXI_FUNCTION(0x2, "i2c0")), /* SCK */ > + SUNXI_FUNCTION(0x2, "i2c0"), /* SCK */ > + SUNXI_FUNCTION_VARIANT(0x3, > + "pll_lock_dbg", > + PINCTRL_SUN8I_R40)), You have a number of lines where the wrapping is not consistent with the rest, such as this one, but also... > SUNXI_PIN(SUNXI_PINCTRL_PIN(B, 20), > SUNXI_FUNCTION(0x0, "gpio_in"), > SUNXI_FUNCTION(0x1, "gpio_out"), > - SUNXI_FUNCTION(0x2, "i2c2")), /* SCK */ > + SUNXI_FUNCTION(0x2, "i2c2"), /* SCK */ > + SUNXI_FUNCTION_VARIANT(0x4, > + "pwm", /* PWM4 */ > + PINCTRL_SUN8I_R40)), ... this one for example. Please fix this. Looks good otherwise. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] Last step to working Allwinner R40 pinctrl Icenowy Zheng <icenowy@aosc.io> - 2017-07-06 16:30 +0200
[PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Icenowy Zheng <icenowy@aosc.io> - 2017-07-06 16:40 +0200
Re: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-06 23:00 +0200
Re: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Icenowy Zheng <icenowy@aosc.io> - 2017-07-07 01:20 +0200
Re: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-07 11:30 +0200
Re: [PATCH 2/2] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Icenowy Zheng <icenowy@aosc.io> - 2017-07-07 11:30 +0200
[PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Icenowy Zheng <icenowy@aosc.io> - 2017-07-06 16:40 +0200
Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-06 22:50 +0200
Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver icenowy@aosc.io - 2017-07-07 01:30 +0200
Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-07-10 10:50 +0200
Re: [linux-sunxi] Re: [PATCH 1/2] pinctrl: sunxi: add a missing function of A10/A20 pinctrl driver Icenowy Zheng <icenowy@aosc.io> - 2017-07-10 12:30 +0200
csiph-web