Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for pm33xx

From	Dave Gerlach <d-gerlach@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for pm33xx
Date	2017-07-06 21:20 +0200
Message-ID	<u0ktH-1dP-5@gated-at.bofh.it> (permalink)
References	<tIWnL-7i2-3@gated-at.bofh.it> <tIWnL-7i2-23@gated-at.bofh.it> <tZcRA-47B-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/03/2017 11:58 AM, Johan Hovold wrote:
> On Fri, May 19, 2017 at 03:04:38PM -0500, Dave Gerlach wrote:
>> Add amx3_common_pm_init to create a dummy platform_device for
>> pm33xx so that our pm33xx module can probe and am335x and am437x
>> platforms to enable basic suspend to mem and standby support.
>>
>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
>> ---
> 
>> +void __init amx3_common_pm_init(void)
>> +{
>> +	struct platform_device_info devinfo = { };
> 
> You should make sure devinfo is zeroed, and also set .id to -1. 

Thanks for the comment, will look into updating this for next version.

Regards,
Dave

> 
>> +	struct am33xx_pm_platform_data *pdata;
>> +
>> +	pdata = am33xx_pm_get_pdata();
>> +	devinfo.name = "pm33xx";
>> +	devinfo.data = pdata;
>> +	devinfo.size_data = sizeof(*pdata);
>> +	platform_device_register_full(&devinfo);
>> +}
> 
> Johan
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for  pm33xx Johan Hovold <johan@kernel.org> - 2017-07-03 19:00 +0200
  Re: [PATCH v2 5/5] ARM: OMAP2+: Create dummy platform_device for  pm33xx Dave Gerlach <d-gerlach@ti.com> - 2017-07-06 21:20 +0200

csiph-web