Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682450

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

Show all headers | View raw

Hi Richard

> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt b/Documentation/devicetree/bindings/net/fsl-fec.txt
> index 6f55bdd..1766579 100644
> --- a/Documentation/devicetree/bindings/net/fsl-fec.txt
> +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
> @@ -23,6 +23,9 @@ Optional properties:
>  - phy-handle : phandle to the PHY device connected to this device.
>  - fixed-link : Assume a fixed link. See fixed-link.txt in the same directory.
>    Use instead of phy-handle.
> +- phy-reset-after-clk-enable : If present then a phy reset and configuration
> +  will be performed everytime after the clocks are enabled. This is required
> +  for some PHYs to work properly.

It sounds like this issue will apply to any LAN8710 which has its
clock fiddled with. So this should be a centrally documented property,
which any MAC driver can implement. Please move the above text to
ethernet.txt, and instead have:

 - phy-reset-after-clk-enable : See ethernet.txt

 Thanks
	 Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option Richard Leitner <richard.leitner@skidata.com> - 2017-07-06 15:20 +0200
  Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Andrew Lunn <andrew@lunn.ch> - 2017-07-06 16:00 +0200
    Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Richard Leitner <richard.leitner@skidata.com> - 2017-07-06 16:40 +0200
  RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Andy Duan <fugang.duan@nxp.com> - 2017-07-07 07:40 +0200
    Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Richard Leitner <richard.leitner@skidata.com> - 2017-07-07 08:10 +0200
      RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Andy Duan <fugang.duan@nxp.com> - 2017-07-07 09:10 +0200
        Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Richard Leitner <richard.leitner@skidata.com> - 2017-07-07 12:00 +0200
          RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Andy Duan <fugang.duan@nxp.com> - 2017-07-07 13:10 +0200
            Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Richard Leitner <richard.leitner@skidata.com> - 2017-07-07 13:20 +0200
              Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Andrew Lunn <andrew@lunn.ch> - 2017-07-07 16:10 +0200
                Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Richard Leitner <richard.leitner@skidata.com> - 2017-07-12 11:40 +0200
                Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Andrew Lunn <andrew@lunn.ch> - 2017-07-12 15:50 +0200
  Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable  option Rob Herring <robh@kernel.org> - 2017-07-10 15:30 +0200

csiph-web